Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add guard for phantom event #271

Merged
merged 2 commits into from
Oct 30, 2020
Merged

fix: Add guard for phantom event #271

merged 2 commits into from
Oct 30, 2020

Conversation

HazAT
Copy link
Member

@HazAT HazAT commented Oct 29, 2020

No description provided.

@HazAT HazAT requested a review from jan-auer October 29, 2020 08:42
@HazAT HazAT self-assigned this Oct 29, 2020
Copy link
Member

@jan-auer jan-auer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I have a theory about this. Here, we call the generic captureEvent:

// @ts-ignore __INTERNAL_MINIDUMP is not assignable to event
captureEvent({ __INTERNAL_MINIDUMP: true });

This is a scope listener on a hub, so I would expect that it always routes to the right backend, but what if a different client is bound? Particularly, it says crashed_process: browser in those events, so potentially this is being routed through the wrong client?

I was wondering if we should just be calling the backend's sendEvent directly rather than the generic captureEvent there.

src/main/backend.ts Outdated Show resolved Hide resolved
Co-authored-by: Jan Michael Auer <[email protected]>
@HazAT
Copy link
Member Author

HazAT commented Oct 30, 2020

It has to go through captureEvent to have all the context for the event. I am going to ship this and lets see.

@HazAT HazAT merged commit 089f9c4 into master Oct 30, 2020
@HazAT HazAT deleted the fix/phantom-event branch October 30, 2020 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants