fix: Create error object in case we cant detect it #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jan-auer
approved these changes
Jul 7, 2020
| @@ -37,8 +38,16 @@ export class OnUncaughtException implements Integration { | |||
| level: Severity.Fatal, | |||
| })); | |||
|
|
|||
| let theError = error; | |||
| if (!isError(error) && error.message && error.stack && error.name) { | |||
There was a problem hiding this comment.
Note that this is falsy if any of the attributes is empty. Do you rather mean to check for undefined?
There was a problem hiding this comment.
Good point, I made it to only check for stack which makes it less strict.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a weird bug where we capture an exception which isn't detected as an error and therefore be captured as
Non-Error exception captured with keys: message, name, stack