fix: Many improvements #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timfish
changed the title
timfish
commented
Feb 26, 2018
| if (process.env['E2E_USERDATA_DIRECTORY']) { | ||
| app.setPath('userData', process.env['E2E_USERDATA_DIRECTORY']); | ||
| } | ||
|
|
There was a problem hiding this comment.
If the app is running e2e tests, we have to change userData directory very early, certainly before Sentry is started
timfish
commented
Feb 26, 2018
| }); | ||
|
|
||
| after(() => { | ||
| afterEach(async () => { | ||
| if (app && app.isRunning()) { | ||
| return app.stop(); |
There was a problem hiding this comment.
Ideally, every test should run in its own fresh instance of the app
timfish
commented
Feb 26, 2018
|
|
||
| expect(normalizeUrl('file:https:///C:/Program%20Files/My%20App/resources/app.asar/a/index.html', base)) | ||
| .to.equal('app:https://a/index.html'); | ||
| }); |
There was a problem hiding this comment.
Still need to check this all on macOS and Linux.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
unitande2eelectron-mochaand e2e inmochats-node/registerso TypeScript tests don't require pre-compilation stepnormalizeUrland add some initial tests (Fixes URL normalization does cater for URL encoded characters #21)