-
-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The main process freezes after enable main process anr #830
Comments
Thanks for the detailed report. I guess we might need to disable ANR between suspend and resume events from the powerMonitor module. |
@timfish Do we have a disable ANR api or this API will be added in the future? |
I haven't seen this happen myself but I will be investigating it and spending time trying to fix it. if you're seeing hanging issues caused by this I would avoid using the ANR feature until this issue is marked as closed. This kind of issue is particularly painful from my point of view because it sounds like it's not 100% reproducible so very tricky to add to our integration tests to ensure it doesn't occur or regress again later! |
Yes, it's not 100% reproducible. We currently haven't found a stable path to reproduce the issue. We have many colleagues testing together, so the probability of reproduction is somewhat higher. |
With the Electron SDK, we have an issue (getsentry/sentry-electron#830) where ANR causes the app to freeze when the machine goes through a suspend/resume cycle. This PR exposes `stopWorker` and `startWorker` methods which can be used in the downstream [ANR integration wrapper](https://github.com/getsentry/sentry-electron/blob/master/src/main/integrations/anr.ts) to stop the ANR feature before device suspend and start it again on device resume.
…1214) With the Electron SDK, we have an issue (getsentry/sentry-electron#830) where ANR causes the app to freeze when the machine goes through a suspend/resume cycle. This PR exposes `stopWorker` and `startWorker` methods which can be used in the downstream [ANR integration wrapper](https://github.com/getsentry/sentry-electron/blob/master/src/main/integrations/anr.ts) to stop the ANR feature before device suspend and start it again on device resume.
Is there an existing issue for this?
How do you use Sentry?
Sentry Saas (sentry.io)
Electron SDK Version
4.17.0
Electron Version
27.2.0
What platform are you using?
MacOS
Link to Sentry event
No response
Steps to Reproduce
It doesn't happen every time, but it occurs more frequently under low battery conditions.
The hangs stack is in v8:debugger and inspector.
Sentry ANR is implemented using a debugger(https://github.com/getsentry/sentry-javascript/blob/develop/packages/node/src/integrations/anr/worker.ts), and it should match up with the above stack info. Disabling Sentry ANR prevents the issue from being reproduced.
Expected Result
main process should not freeze after wakeup
Actual Result
main process freezes after wakeup
The text was updated successfully, but these errors were encountered: