Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Don't capture window titles by default with ElectronBreadcrumbs integration #463

Merged
merged 2 commits into from
Apr 11, 2022
Merged

fix: Don't capture window titles by default with ElectronBreadcrumbs integration #463

merged 2 commits into from
Apr 11, 2022

Conversation

timfish
Copy link
Collaborator

@timfish timfish commented Apr 7, 2022

Fixes #459

To re-enable:

init({
  dsn: '__DSN__',
  integrations: [new ElectronBreadcrumbs({ includeWindowTitles: true })]
})

@timfish
Copy link
Collaborator Author

timfish commented Apr 7, 2022

includeWindowTitles 🤔

Maybe captureWindowTitles would be better?

AbhiPrasad
AbhiPrasad reviewed Apr 7, 2022
View reviewed changes
Copy link
Member

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like captureWindowTitles.

src/main/integrations/electron-breadcrumbs.ts
} else if (typeof val === 'function' || val === false) {
obj[k] = val;
if (k === 'includeWindowTitles') {
obj[k] = !!options[k];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there really no way to avoid this special case?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the previous properties are of the same type so could be treated equally

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At least it's type checked 🤷

AbhiPrasad
AbhiPrasad approved these changes Apr 7, 2022
View reviewed changes
Copy link
Member

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need to update docs as well?

@timfish timfish merged commit ef1839a into getsentry:master Apr 11, 2022
@timfish timfish deleted the fix/no-window-titles-default branch April 14, 2022 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbhiPrasad AbhiPrasad AbhiPrasad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ElectronBreadcrumbs integration captures window titles by default
2 participants
@timfish @AbhiPrasad