Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ElectronBreadcrumbs integration captures window titles by default #459

Closed
timfish opened this issue Apr 5, 2022 · 3 comments · Fixed by #463
Closed

ElectronBreadcrumbs integration captures window titles by default #459

timfish opened this issue Apr 5, 2022 · 3 comments · Fixed by #463

Comments

@timfish
Copy link
Collaborator

timfish commented Apr 5, 2022

Versions + Platform

Description

cc @smeubank

The ElectronBreadcrumbs integration captures window titles by default and these may contain PII. This can currently be worked around by removing the integration but this level of data capture should be configurable.

@timfish
Copy link
Collaborator Author

timfish commented Apr 5, 2022

While we work out how best to make this configurable you can remove window titles via the beforeSend hook:

Sentry.init({
  // other options...
  beforeSend: (event) => {
    for (const breadcrumb of event.breadcrumbs || []) {
      if (breadcrumb?.data?.title) {
        delete breadcrumb.data.title;
      }
    }
    return event;
  }
})

@timfish
Copy link
Collaborator Author

timfish commented Apr 6, 2022

The obvious choice for a config option is the integration constructor:

init({
  dsn: '__DSN__',
  integrations: [new ElectronBreadcrumbs({ includeWindowTitles: true })]
})

@timfish
Copy link
Collaborator Author

timfish commented Apr 12, 2022

A fix for this has been released in 3.0.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant