feat: Do not start crash reporter in renderer #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jan-auer
approved these changes
Jan 23, 2021
There was a problem hiding this comment.
AFAIK, crashReporter is still defined, so you could just check for:
if (!crashReporter.start) return;Overall approach LGTM. We still need to start the crash reporter in renderer processes in old versions to support Linux where Breakpad was (?) used for crash reporting. There is no harm to initializing the crash reporter in versions where the API is still available.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This disables the starting of the crash handler in the renderer process. This is necessary for it to work on Electron 12.
This still needs validation.
Fixes #229