Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crashReporter is deprecated in renderer (9+) will be removed (12+) #229

Closed
3 tasks
ChrisHSandN opened this issue Jun 2, 2020 · 0 comments · Fixed by #290
Closed
3 tasks

crashReporter is deprecated in renderer (9+) will be removed (12+) #229

ChrisHSandN opened this issue Jun 2, 2020 · 0 comments · Fixed by #290

Comments

@ChrisHSandN
Copy link

Versions + Platform

Description

Including sentry in the renderer causes the following warning to be emmited:

deprecate.ts:33 (electron) crashReporter.start is deprecated in the renderer process. Call it from the main process instead.

Call comes from:

sentry-electron/src/renderer/backend.ts

Line 102 in 5ac5a8c

crashReporter.start({

Electron crashReporter docs noting deprecation:
https://www.electronjs.org/docs/api/crash-reporter#crashreporterstartoptions

Electron breaking changes docs:
https://www.electronjs.org/docs/breaking-changes

Also in Electron 10+:

The companyName argument to crashReporter.start(), which was previously required, is now optional, and further, is deprecated. To get the same behavior in a non-deprecated way, you can pass a companyName value in globalExtra.
hatton added a commit to onset/lameta that referenced this issue Oct 10, 2020
@hatton
wip switch to sentry electron
2f07834 
Why??? in the vain hope it will somehow help with sourcemaps? It will also send errors that happen in the main process.

I have it compiling and sending, but the resulting report had even less stack trace (not even method names).

Also, getsentry/sentry-electron#229 is happening, given an error "crashReporter is deprecated in renderer".
@mitsuhiko mitsuhiko mentioned this issue Jan 22, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Do not start crash reporter in renderer getsentry/sentry-electron
1 participant
@ChrisHSandN