Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default breadcrumbs are getting a bit noisy #181

Closed
timfish opened this issue Sep 2, 2019 · 0 comments · Fixed by #336
Closed

Default breadcrumbs are getting a bit noisy #181

timfish opened this issue Sep 2, 2019 · 0 comments · Fixed by #336
Assignees
@timfish

Comments

@timfish
Copy link
Collaborator

timfish commented Sep 2, 2019

As of Electron v4, the default breadcrumbs from Electron events are getting a bit noisy. We probably need to exclude app.remote-get-builtin, app.remote-get-global and app.remote-get-current-window:

image
@timfish timfish self-assigned this Nov 14, 2019
@tommoor tommoor mentioned this issue Nov 15, 2019
Closed
timfish added a commit to timfish/sentry-electron that referenced this issue May 27, 2021
@timfish
Fixes getsentry#181 by removing breadcrumbs for remote- events
3048e4c
@timfish timfish mentioned this issue May 27, 2021
Merged
timfish added a commit that referenced this issue Jun 14, 2021
@timfish
Fix: Few minor improvements (#336)
717a4e8 
* Improve error text #222
* Fix for #277 #205
* Fixes #181 by removing breadcrumbs for `remote-` events
* Use taskkill after each test on Windows to try and make CI more reliable
* Update changelog
* Add Electron 13 to tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@timfish timfish

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: Few minor improvements timfish/sentry-electron
1 participant
@timfish