Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add healthchecks for redis, memcached and postgres #975

Merged
merged 2 commits into from
Jun 2, 2021
Merged

feat: Add healthchecks for redis, memcached and postgres #975

merged 2 commits into from
Jun 2, 2021

Conversation

williamdes
Copy link
Contributor

@williamdes williamdes commented May 29, 2021 •
edited
Loading

Ref: #950

@williamdes
Copy link
Contributor Author

williamdes commented May 29, 2021 •
edited
Loading

For postgres

    healthcheck:
      test: ["CMD-SHELL", "pg_isready -U sentry"]
      interval: 10s
      timeout: 5s
      retries: 5
      start_period: 10s

But I would need to know the username

@BYK BYK changed the title Add healthchecks for redis and memcached feat: Add healthchecks for redis and memcached May 30, 2021
@BYK
Copy link
Member

BYK commented May 30, 2021

But I would need to know the username

Looks like we just use the default username:

https://github.com/getsentry/onpremise/blob/e20e6a3e5483ddfda6d3d9c07cb9ea53d3d22731/sentry/sentry.conf.example.py#L40

@BYK BYK enabled auto-merge (squash) May 30, 2021 11:37
BYK
BYK approved these changes May 30, 2021
View reviewed changes
docker-compose.yml Outdated Show resolved Hide resolved
docker-compose.yml Outdated Show resolved Hide resolved
@BYK BYK disabled auto-merge May 30, 2021 11:39
@williamdes williamdes changed the title feat: Add healthchecks for redis and memcached feat: Add healthchecks for redis, memcached and postgres Jun 2, 2021
BYK
BYK reviewed Jun 2, 2021
View reviewed changes
docker-compose.yml Outdated Show resolved Hide resolved
@BYK BYK enabled auto-merge (squash) June 2, 2021 18:44
@BYK BYK merged commit f4c3096 into getsentry:master Jun 2, 2021
@williamdes williamdes deleted the healhchecks branch June 2, 2021 19:43
@github-actions github-actions bot locked and limited conversation to collaborators Jun 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BYK BYK BYK approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@williamdes @BYK