Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow metric alerts to be used in on-prem #735

Merged
merged 1 commit into from
Nov 13, 2020
Merged

Conversation

wedamija
Copy link
Member

This enables metric alerts for all on-prem users. There wasn't too much to do, mostly just making
sure the consumers are running, and then enabling the feature.

This enables metric alerts for all on-prem users. We just need to start a few consumers and enable
the feature.
@wedamija wedamija requested a review from BYK November 11, 2020 00:07
@wedamija
Copy link
Member Author

wedamija commented Nov 11, 2020

I tested this locally and saw metric alerts fire, so this should be good to go.

Looking at the logs, initially I saw some cimpl.KafkaException: KafkaError{code=UNKNOWN_TOPIC_OR_PART,val=3,str="Subscribed topic not available: events-subscription-results: Broker: Unknown topic or partition"}. This should resolve itself as events come in, but if we want to avoid it we could set KAFKA_CONSUMER_AUTO_CREATE_TOPICS = True in the config. Then once getsentry/sentry#21801 is merged we should be good.

@BYK
Copy link
Member

BYK commented Nov 11, 2020

This should resolve itself as events come in, but if we want to avoid it we could set KAFKA_CONSUMER_AUTO_CREATE_TOPICS = True in the config.

Can we set this in https://github.com/getsentry/sentry/blob/master/docker/sentry.conf.py or in our default server.py config?

Copy link
Member

@BYK BYK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for the comment I left. Also I'm assuming you tested this?

@wedamija
Copy link
Member Author

This should resolve itself as events come in, but if we want to avoid it we could set KAFKA_CONSUMER_AUTO_CREATE_TOPICS = True in the config.

Can we set this in https://github.com/getsentry/sentry/blob/master/docker/sentry.conf.py or in our default server.py config?

Actually it is already set to True, I realised I just saw the error due to getsentry/sentry#21801 not being merged.

LGTM except for the comment I left. Also I'm assuming you tested this?

Yep, mentioned in a comment above.

@wedamija wedamija requested a review from BYK November 13, 2020 01:47
@BYK BYK merged commit 066bf26 into master Nov 13, 2020
@BYK BYK deleted the danf/metric_alerts branch November 13, 2020 10:39
@BYK
Copy link
Member

BYK commented Nov 13, 2020

/cc @markstory @chadwhitacre

@github-actions github-actions bot locked and limited conversation to collaborators Dec 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants