Add volumed-out config directory for symbolicator. #566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jan-auer
approved these changes
Jul 6, 2020
There was a problem hiding this comment.
LGTM, thanks @mikepurvis.
Leaving final review to @BYK. See the linked issue for context.
|
Why not do this with a |
|
@BYK I don't have a strong opinion on that. I was just following the pattern of |
mikepurvis
commented
Jul 8, 2020
jan-auer
approved these changes
Jul 8, 2020
|
@mikepurvis thank you very much for taking the time to share your solution with us and the broader community and pushing us for a better developer experience. Very much appreciated! 🎉 |
|
Thanks for the quick merge! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to be able to customize the configuration for my Sentry 10 symbolicator instance, which this change allows me to easily do.
See related: getsentry/symbolicator#245