Use general kafka topic creation in self-hosted #3121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #3121 +/- ##
=======================================
Coverage 99.01% 99.01%
=======================================
Files 3 3
Lines 203 203
=======================================
Hits 201 201
Misses 2 2 ☔ View full report in Codecov by Sentry. |
hubertdeng123
changed the title
|
Nice, love it! A bit weird that this flag is not enabled by default though. |
Reason why I made it an opt-in flag is because this command is used during migration tests and devenv and didn't want to risk breaking anything there. |
azaslavsky
approved these changes
Jun 12, 2024
hubertdeng123
deleted the
hubertdeng123/move-kafka-topics-creation-to-upgrade-command
branch
jamesbaber1
pushed a commit
to Algo-Trading-Tools/sentry
that referenced
this pull request
Jun 20, 2024
* use general kafka topic creation
|
While upgrading to 24.6.0 i get the following error Error: No such option: --create-kafka-topics
Error in install/set-up-and-migrate-database.sh:30.
'$dcr web upgrade --create-kafka-topics' exited with status 2
-> ./install.sh:main:38
--> install/set-up-and-migrate-database.sh:source:30
Cleaning up... |
I forgot to update the versions in |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to getsentry/sentry#72338. We can now handle topic creation automatically versus manually listing out topics needed.