Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update consumer flags #3112

Merged

Conversation

hubertdeng123
Copy link
Member

@hubertdeng123 hubertdeng123 commented Jun 4, 2024

talked to @lynnagara, ingest consumers are not run with --no-strict-offset-reset, but post process forwarders are

This should fix #2951

Copy link

codecov bot commented Jun 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.08%. Comparing base (f8e95ec) to head (9095de9).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3112      +/-   ##
==========================================
- Coverage   99.01%   94.08%   -4.93%     
==========================================
  Files           3        3              
  Lines         203      203              
==========================================
- Hits          201      191      -10     
- Misses          2       12      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hubertdeng123 hubertdeng123 enabled auto-merge (squash) June 4, 2024 19:04
@hubertdeng123 hubertdeng123 merged commit 3455a33 into master Jun 4, 2024
12 of 13 checks passed
@hubertdeng123 hubertdeng123 deleted the hubertdeng123/fix-no-strict-offset-reset-flags branch June 4, 2024 19:07
jamesbaber1 pushed a commit to Algo-Trading-Tools/sentry that referenced this pull request Jun 20, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jun 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

OffsetOutOfRange errors have returned
3 participants