Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(spans): Add new feature flags needed #3092

Merged
merged 4 commits into from
May 29, 2024

Conversation

phacops
Copy link
Contributor

@phacops phacops commented May 29, 2024

We split the feature flags for span ingestion in 3 different buckets:

  • indexed spans
  • metrics extraction for some modules
  • metrics extraction for add-on modules

This PR will make sure all 3 features are now enabled in self-hosted.

@phacops phacops enabled auto-merge (squash) May 29, 2024 16:07
Copy link

codecov bot commented May 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.01%. Comparing base (6917e39) to head (3db19ad).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3092   +/-   ##
=======================================
  Coverage   99.01%   99.01%           
=======================================
  Files           3        3           
  Lines         203      203           
=======================================
  Hits          201      201           
  Misses          2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

"organizations:insights-initial-modules",
"organizations:mobile-ttid-ttfd-contribution",
"organizations:performance-calculate-score-relay",
"organizations:performance-database-view",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is obsolete! No harm, but this flag isn't in use

"organizations:mobile-ttid-ttfd-contribution",
"organizations:performance-calculate-score-relay",
"organizations:performance-database-view",
"organizations:performance-screens-view",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also obsolete

@phacops phacops disabled auto-merge May 29, 2024 16:30
@hubertdeng123 hubertdeng123 merged commit ede1e6f into master May 29, 2024
13 checks passed
@hubertdeng123 hubertdeng123 deleted the pierre/spans-add-new-feature-flags branch May 29, 2024 17:32
@github-actions github-actions bot locked and limited conversation to collaborators Jun 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants