Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade clickhouse to 23.8 #3009

Merged
merged 10 commits into from
May 6, 2024
Merged

Upgrade clickhouse to 23.8 #3009

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
c0277a6
upgrade clickhouse
hubertdeng123 May 1, 2024
be7adcc
add newline
hubertdeng123 May 1, 2024
4cf5b79
check to see if it is an upgrade
hubertdeng123 May 2, 2024
ffc1e1e
get rid of -it option
hubertdeng123 May 2, 2024
c3d1eca
Merge branch 'master' into hubertdeng123/upgrade-ch
hubertdeng123 May 2, 2024
8bf4edc
wait for clickhouse to come up
hubertdeng123 May 2, 2024
3b4c94f
fix hard stops on upgrade
hubertdeng123 May 3, 2024
369873c
add message about skipping clickhouse upgrades
hubertdeng123 May 3, 2024
7f15b3c
add comment about upgrading clickhouse version
hubertdeng123 May 3, 2024
28196c2
the fix
hubertdeng123 May 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
get rid of -it option
  • Loading branch information
@hubertdeng123
hubertdeng123 committed May 2, 2024
commit ffc1e1ecd1fad6c4b68b49b88933e7877810136e
2 changes: 1 addition & 1 deletion install/upgrade-clickhouse.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ echo "${_group}Upgrading Clickhouse ..."
if [[ -n "$(docker volume ls -q --filter name=sentry-clickhouse)" ]]; then
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonder if it's worth adding a test for this? Should (hopefully) be pretty straightforward with the new python-based testing regime?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Editing the install script is not easily tested using the new python tests. Those are effective after self-hosted sentry is installed and up and running. The new self-hosted Sentry upgrade tests I added sufficiently covers this IMO, it skips over this portion of the code on initial install and hits this on the upgrade

# In order to get to 23.8, we need to first upgrade go from 21.8 -> 22.8 -> 23.3 -> 23.8
$dc up -d clickhouse
version=$($dc exec -it clickhouse clickhouse-client -q 'SELECT version()')
version=$($dc exec clickhouse clickhouse-client -q 'SELECT version()')
if [[ "$version" == "22.8.15.25.altinitystable" || "$version" == "21.8.12.29.altinitydev.arm" ]]; then
$dc down clickhouse
$dcb --build-arg BASE_IMAGE=altinity/clickhouse-server:22.8.15.25.altinitystable clickhouse
Expand Down
Loading