Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix master test failures #3000

Merged
merged 3 commits into from
Apr 26, 2024
Merged

Fix master test failures #3000

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
74ebf1d
fix for tests?
hubertdeng123 Apr 26, 2024
a4e9a0f
fix tests on master
hubertdeng123 Apr 26, 2024
6438ddd
Merge branch 'master' into hubertdeng123/fix-master-test-failures
hubertdeng123 Apr 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix tests on master
  • Loading branch information
@hubertdeng123
hubertdeng123 committed Apr 26, 2024
commit a4e9a0fd1c3ba7a9cf201e8d09109d955621904a
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ jobs:
if [ "${{ matrix.compose_version }}" = "v2.0.1" ]; then
pytest --reruns 3 --cov --junitxml=junit.xml _integration-test/ --customizations=${{ matrix.customizations }}
else
pytest -rA --cov --junitxml=junit.xml _integration-test/ --customizations=${{ matrix.customizations }}
pytest --cov --junitxml=junit.xml _integration-test/ --customizations=${{ matrix.customizations }}
fi

- name: Inspect failure
Expand Down
3 changes: 1 addition & 2 deletions _integration-test/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,7 @@
with open("sentry/requirements.txt", "w") as req_file:
req_file.write("python-ldap\n")
os.environ["MINIMIZE_DOWNTIME"] = "1"
output = subprocess.run(["./install.sh"], check=True, capture_output=True)
print(output)
subprocess.run(["./install.sh"], check=True, capture_output=True)

Check warning on line 55 in _integration-test/conftest.py

View check run for this annotation

Codecov / codecov/patch

_integration-test/conftest.py#L55 

Added line #L55 was not covered by tests
# Create test user
subprocess.run(
[
Expand Down
Loading