Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write Customization tests in python #2918

Merged
merged 18 commits into from
Mar 26, 2024
Merged

Write Customization tests in python #2918

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
981afa1
port everything to python
hubertdeng123 Mar 21, 2024
23bade6
use autouse fixture
hubertdeng123 Mar 22, 2024
fa0bcaa
fix precommit
hubertdeng123 Mar 22, 2024
ac67a3b
fix some syntax issues
hubertdeng123 Mar 22, 2024
fd28ad4
reinstall self-hosted after making customizations
hubertdeng123 Mar 22, 2024
68da8b0
add codecov
hubertdeng123 Mar 22, 2024
5c2fd16
track flaky test failures
hubertdeng123 Mar 22, 2024
2ccd1a5
only enable flaky tests for master
hubertdeng123 Mar 22, 2024
82eed1e
catch exception for general httpx networkerror
hubertdeng123 Mar 25, 2024
fbe3713
add test customizations
hubertdeng123 Mar 25, 2024
1799f09
customization tests working finally?
hubertdeng123 Mar 25, 2024
867ed00
add newline to eof
hubertdeng123 Mar 25, 2024
fb6d766
fix customizations tests
hubertdeng123 Mar 25, 2024
fe79de0
add -c flag
hubertdeng123 Mar 25, 2024
b61dd79
remove no longer needed shell files
hubertdeng123 Mar 25, 2024
6732677
try and set custom name for integration test jobs
hubertdeng123 Mar 26, 2024
a6fa7b0
add customizations enabled
hubertdeng123 Mar 26, 2024
2594145
use retries on installing self hosted
hubertdeng123 Mar 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Prev Previous commit
Next Next commit
add newline to eof
  • Loading branch information
@hubertdeng123
hubertdeng123 committed Mar 25, 2024
commit 867ed00e5ad6b8afd8df84ba52a167ecb14bbe5a
2 changes: 1 addition & 1 deletion _integration-test/test_run.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,6 +239,6 @@
for command in commands:
result = subprocess.run(command, check=False)
if os.getenv("TEST_CUSTOMIZATIONS", "False") == "True":
assert result.returncode == 0

Check warning on line 242 in _integration-test/test_run.py

View check run for this annotation

Codecov / codecov/patch

_integration-test/test_run.py#L242 

Added line #L242 was not covered by tests
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does test_customization run in both matrix variants?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it does. If customizations enabled, it checks to ensure that they are truly enabled by making sure a dependency can be imported that is included in the custom image (ldap). If not, it checks to ensure that an error is thrown when trying to import a dependency that comes from the custom image.

else:
assert result.returncode != 0
assert result.returncode != 0