Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integration test improvements #2858

Merged
merged 11 commits into from
Mar 7, 2024
Merged

Integration test improvements #2858

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
02ccedd
integration test improvements
hubertdeng123 Mar 6, 2024
07c059e
fix sentry send event
hubertdeng123 Mar 6, 2024
364d0d2
install self-hsoted as separate step in gh action
hubertdeng123 Mar 6, 2024
9dd9ac0
do not report self-hosted issues during install
hubertdeng123 Mar 6, 2024
c21576f
run jobs for compose v2.0.1 and v2.7.0
hubertdeng123 Mar 6, 2024
4308b2c
incorporate sentry dsn for testing into existing logic
hubertdeng123 Mar 6, 2024
b22f1eb
fix test type
hubertdeng123 Mar 7, 2024
9c4fbfc
remove retries for now
hubertdeng123 Mar 7, 2024
ffabc9f
comment onto using exec
hubertdeng123 Mar 7, 2024
2ced8fb
fix error reporting
hubertdeng123 Mar 7, 2024
7559e55
add error handling to test.sh
hubertdeng123 Mar 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix sentry send event
  • Loading branch information
@hubertdeng123
hubertdeng123 committed Mar 6, 2024
commit 07c059e46ebaaf75fd64a78e8d465d8d0cf101d3
5 changes: 3 additions & 2 deletions _integration-test/run.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,11 +28,12 @@ teardown() {
DID_TEAR_DOWN=1

if [ "$1" != "EXIT" ]; then
set +x
error_msg="An error occurred, caught SIG$1 on line $2"
echo "$error_msg"
dsn="https://[email protected]/6627632"
sentry_cli="docker run --rm -v /tmp:/work -e SENTRY_DSN=$dsn getsentry/sentry-cli"
$sentry_cli send-event -m "$error_msg" --logfile "$log_file"
local sentry_cli="docker run --rm -v $(pwd):/work -e SENTRY_DSN=$dsn getsentry/sentry-cli"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Odd to me that we set REPORT_ISSUES=0 above, but then send an envelope here anyway? Maybe I am misunderstanding something, but why would we not just do REPORT_ISSUES=1, and maybe figure out some way to configure it to send to an "integration tests" or similar project on our actual dogfood instance?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I can incorporate this into the existing logic for REPORT_ISSUES I believe.

$sentry_cli send-event -m "$error_msg" --logfile $log_file
fi

echo "Tearing down ..."
Expand Down
Loading