Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create README-zh.md #2693

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

beyondverage0908
Copy link

Add Chinese readme file

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

Add Chinese readme file
Copy link
Collaborator

@aminvakil aminvakil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is needed.

Copy link

@RayWP RayWP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chadwhitacre
Copy link
Member

@beyondverage0908 @RayWP If we merge this, can we count on you to help us keep it up-to-date as we make other README changes?

@chadwhitacre
Copy link
Member

We'll also need to get this passing CI, looks like maybe trailing whitespace?

@chadwhitacre
Copy link
Member

Hrm, I think you posted then deleted @RayWP? 🤔

Either way, I'm good to merge this once we clean up the pre-commit check.

@chadwhitacre
Copy link
Member

chadwhitacre commented Jan 18, 2024

django.core.cache.backends.base.InvalidCacheBackendError:
  Could not find backend 'django.core.cache.backends.memcached.MemcachedCache':
  Module "django.core.cache.backends.memcached" does not define a "MemcachedCache" attribute/class

https://github.com/getsentry/self-hosted/actions/runs/7571747446/job/20619977561?pr=2693#step:4:4039

Spurious? 🤔

Doesn't fee like it, same in the others:

https://github.com/getsentry/self-hosted/actions/runs/7571747446/job/20619978008?pr=2693#step:4:3841
https://github.com/getsentry/self-hosted/actions/runs/7571747446/job/20619978441?pr=2693#step:4:3841

Random instance of the word "memcache" crossing my radar at roughly the same time ... probably not directly related, but maybe?

@chadwhitacre
Copy link
Member

Rerunning failures ...

@chadwhitacre
Copy link
Member

Still failing, need to dig deeper.

@hubertdeng123
Copy link
Member

@chadwhitacre maybe this will fix the issue?
#2722

@hubertdeng123
Copy link
Member

tests are now passing, precommit needs to be fixed though

@liukch
Copy link

liukch commented Jun 19, 2024

I use Chinese in my daily life, but the content of this PR looks like it was translated using a translation software, and the quality is very poor, making it difficult to read.

@BYK
Copy link
Member

BYK commented Jun 19, 2024

@liukch thanks for the feedback! Do you think you can help improve it?

@liukch
Copy link

liukch commented Jun 20, 2024

I don't think it's necessary to provide Chinese translations, and it would also require a lot of effort to keep them up-to-date.

@BYK If you really need Chinese translations, please let me know, and I will improve them. However, I cannot guarantee that I can keep them up-to-date in the long future.

@BYK
Copy link
Member

BYK commented Jun 20, 2024

Then I'm inclined to close this out in favor of #1996. That way we may also think about a more general way for translating our docs.

Thoughts @aldy505 @hubertdeng123 @chadwhitacre?

@aldy505
Copy link
Collaborator

aldy505 commented Jun 20, 2024

Then I'm inclined to close this out in favor of #1996. That way we may also think about a more general way for translating our docs.

Thoughts @aldy505 @hubertdeng123 @chadwhitacre?

I'm up for it! Let's focus more on #1996.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

None yet

8 participants