Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run tests only on getsentry repository #2681

Merged
merged 1 commit into from
Jan 12, 2024

Conversation

aminvakil
Copy link
Collaborator

Run tests only on getsentry repository.

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@aminvakil
Copy link
Collaborator Author

aminvakil commented Jan 2, 2024

Superseded by #2682.

@aminvakil aminvakil closed this Jan 2, 2024
@aminvakil aminvakil deleted the test_main_repo_only branch January 2, 2024 15:09
@aminvakil aminvakil restored the test_main_repo_only branch January 12, 2024 20:04
@aminvakil aminvakil reopened this Jan 12, 2024
@aminvakil
Copy link
Collaborator Author

As discussed in #2682 (comment), I've opened this PR again.

Copy link
Collaborator Author

@aminvakil aminvakil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be better if there was a way which you could specify running the workflow on a specific repository instead of adding a condition on each job, but I didn't know how and after some digging I'm not sure even if that could be accomplished in some way, but if anyone knows how to do this, that would definitely be a better way to do this.

@hubertdeng123
Copy link
Member

It would be better if there was a way which you could specify running the workflow on a specific repository instead of adding a condition on each job, but I didn't know how and after some digging I'm not sure even if that could be accomplished in some way, but if anyone knows how to do this, that would definitely be a better way to do this.

Agreed, I do not think this is possible right now, but I'm happy to be wrong if that's the case

@aminvakil
Copy link
Collaborator Author

Failed with:

  Error response from daemon: Conflict. The container name "/self-hosted-1-snuba-subscription-consumer-metrics-1" is already in use by container "9cbe8403eead4fae97975e4ba385717fd1ed24d419863d51dfa1e977d3436aff". You have to remove (or rename) that container to be able to reuse that name.

😄
#1547

Close and reopen to trigger the CI again.

@aminvakil aminvakil closed this Jan 12, 2024
@aminvakil aminvakil reopened this Jan 12, 2024
@hubertdeng123 hubertdeng123 merged commit b71d147 into getsentry:master Jan 12, 2024
11 of 12 checks passed
@aminvakil aminvakil deleted the test_main_repo_only branch January 13, 2024 00:26
@github-actions github-actions bot locked and limited conversation to collaborators Jan 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants