Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nginx client request body is buffered to a temporary file #2630

Merged
merged 2 commits into from
Dec 28, 2023

Conversation

zKoz210
Copy link
Contributor

@zKoz210 zKoz210 commented Dec 6, 2023

This fixes warnings from nginx and creating temporary files on disk

[warn] 46#46: *133550 a client request body is buffered to a temporary file /var/cache/nginx/client_temp/0000011816, client: 172.30.0.1, server: , request: "POST /api/53/envelope/?sentry_key=-&sentry_version=7&sentry_client=sentry.javascript.vue%2F7.80.0 HTTP/1.0", host: "-", referrer: "-/"

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@aminvakil
Copy link
Collaborator

This change will put pressure on memory on instances, where lots of requests are received simultaneously.

@hubertdeng123
Copy link
Member

Hm, you're right. It may be good to reduce the value of this to something like 32k. Would that still fix the issue for you @zKoz210?

@zKoz210
Copy link
Contributor Author

zKoz210 commented Dec 17, 2023

64k was perfect for me, after that the warnings disappeared

@aminvakil
Copy link
Collaborator

LGTM

@hubertdeng123 hubertdeng123 merged commit 6005ada into getsentry:master Dec 28, 2023
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants