Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add sentry-admin.sh tool #2594

Merged
merged 2 commits into from
Nov 21, 2023
Merged

feat: Add sentry-admin.sh tool #2594

merged 2 commits into from
Nov 21, 2023

Conversation

azaslavsky
Copy link
Contributor

sentry-admin.sh is just a bash wrapper around some admin commands that are already technically exposed in the web container, though a bit hard to find today. This command just forwards the sentry command-line administration tool out from the container onto the host machine, slightly editing the help docs to make it a bit easier to use in the process.

@@ -0,0 +1,50 @@
#!/usr/bin/env bash
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should have two instances of backup in integration tests if it takes too long. It already takes over 25 minutes to run integration tests and this adds to that overhead

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed this 2nd backup test, and modified the original to use sentry-admin.sh instead. We'll modify the docs once this PR lands.

sentry-admin.sh Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we have this sentry-admin tool, I think we can delete the /scripts/backup.sh and /scripts/restore.sh, thoughts?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Along the lines of that, I do think reset.sh could be incorporated here, but that can be done in a follow up PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to keep them for now, since users may be relying on them. We can deprecate-then-delete them in future releases.

Agree on reset.sh.

@azaslavsky azaslavsky enabled auto-merge (squash) November 21, 2023 20:27
@azaslavsky azaslavsky merged commit f00e6a9 into master Nov 21, 2023
8 checks passed
@azaslavsky azaslavsky deleted the azaslavsky/sentry-admin branch November 21, 2023 20:30
@github-actions github-actions bot locked and limited conversation to collaborators Dec 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants