Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Clickhouse to 21.8 #2536

Merged
merged 2 commits into from
Nov 2, 2023
Merged

Conversation

hubertdeng123
Copy link
Member

Upgrades clickhouse for self-hosted users. Tested it out on our own self-hosted Sentry instance and it seems to work smoothly 🤞

@lynnagara
Copy link
Member

lynnagara commented Nov 2, 2023

can you explain the 21.8.13.1.altinitystable vs 21.8.12.29.altinitydev.arm part? i'm wondering if this is also a solution we can use to upgrade sentry dev and align the versions https://github.com/getsentry/sentry/blob/71890e0dabee42c710ad9a82cb68c5f8bdb93bfa/src/sentry/conf/server.py#L2753

@hubertdeng123
Copy link
Member Author

Sure, 21.8.12.29.altinitydev.arm, is an image that is used for dev environments primarily those running on Apple silicon. So I think you can use this to upgrade sentry dev. There sadly doesn't seem to be an arm image for 21.8.13.1 though, so the versions won't be completely aligned.

@hubertdeng123
Copy link
Member Author

tested in dev, it's working for me

lynnagara
lynnagara previously approved these changes Nov 2, 2023
@lynnagara
Copy link
Member

Should we be using the altinitydev.arm versions? Would altinity/clickhouse-server:21.8.12.1.testingarm be better?

@hubertdeng123
Copy link
Member Author

Should we be using the altinitydev.arm versions? Would altinity/clickhouse-server:21.8.12.1.testingarm be better?

Don't think there is much of a difference there as I couldn't find much online. It's newer and the version of clickhouse used is more close to the .testingarm version. Seems fine to use and I've tested it locally

@lynnagara
Copy link
Member

Should we be using the altinitydev.arm versions? Would altinity/clickhouse-server:21.8.12.1.testingarm be better?

Don't think there is much of a difference there as I couldn't find much online. It's newer and the version of clickhouse used is more close to the .testingarm version. Seems fine to use and I've tested it locally

@nikhars Do you know which we should be using here? It was my understanding that the testing versions are generally more stable than the dev ones but I couldn't find details about it online.

@hubertdeng123 hubertdeng123 merged commit ed8cc79 into master Nov 2, 2023
8 checks passed
@hubertdeng123 hubertdeng123 deleted the hubertdeng123/upgrade-clickhouse branch November 2, 2023 19:22
@williamdes
Copy link
Contributor

Does anyone has a reference of why the name changes that would help me trust the new image rather than the Yandex namespace?
Can I just pick the same version on the Yandex repo?

@MeredithAnya
Copy link
Member

MeredithAnya commented Nov 3, 2023

Does anyone has a reference of why the name changes that would help me trust the new image rather than the Yandex namespace? Can I just pick the same version on the Yandex repo?

The Altinity versions are maintained for 3 years, we use Altinity builds in Sentry's production clusters so that we can have more stability when it comes to upgrading our clusters. According to their docs, they are 100% compatible with the community builds: https://docs.altinity.com/altinitystablebuilds/

cc @williamdes

@williamdes
Copy link
Contributor

Thank you!

@Cybernisk
Copy link

Hi @hubertdeng123 should this fix the issue with Replays and Clickhouse mentioned by @cmanallen in getsentry/sentry#57326 (comment) ?
I've moved to altinity/clickhouse-server:21.8.15.15.altinitystable as Allen advised.

@hubertdeng123
Copy link
Member Author

@Cybernisk Yes, this should fix the issue that you have.

@github-actions github-actions bot locked and limited conversation to collaborators Nov 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

6 participants