Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nginx.conf #2455

Merged
merged 2 commits into from
Oct 7, 2023
Merged

Update nginx.conf #2455

merged 2 commits into from
Oct 7, 2023

Conversation

mwarkentin
Copy link
Member

Fixes #2285

Applies the same proxy_hide_header Content-Disposition;, but only to paths that start with _static/ which should avoid the issue introduced previously with attachment downloads.

Fixes #2285

Applies the same `proxy_hide_header Content-Disposition;`, but only to paths that start with `_static/` which should avoid the issue introduced previously with attachment downloads.
Co-authored-by: Amin Vakil <[email protected]>
Copy link
Contributor

@azaslavsky azaslavsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting this! :)

Copy link
Collaborator

@aminvakil aminvakil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

P.S. Users without access cannot approve PRs, otherwise I would just approve it.

@azaslavsky azaslavsky merged commit bd05749 into master Oct 7, 2023
8 checks passed
@azaslavsky azaslavsky deleted the fix-content-disposition-static branch October 7, 2023 00:09
@github-actions github-actions bot locked and limited conversation to collaborators Oct 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Unable to open Sentry with Safari, possibly related to Content-Encoding: gzip
3 participants