Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update outdated install option in README #2440

Merged
merged 2 commits into from
Oct 17, 2023
Merged

Update outdated install option in README #2440

merged 2 commits into from
Oct 17, 2023

Conversation

hubertdeng123
Copy link
Member

Closes #2438

@hubertdeng123 hubertdeng123 requested a review from a team September 29, 2023 21:58
aminvakil
aminvakil reviewed Sep 29, 2023
View reviewed changes
Copy link
Collaborator

@aminvakil aminvakil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this makes the sentence easier to understand and read.

README.md Outdated Show resolved Hide resolved
azaslavsky
azaslavsky requested changes Oct 13, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
@hubertdeng123 @aminvakil
tidy up sentence
a017b15 
Co-authored-by: Amin Vakil <[email protected]>
@hubertdeng123 hubertdeng123 merged commit 79bebdd into master Oct 17, 2023
8 checks passed
@hubertdeng123 hubertdeng123 deleted the hubertdeng123/tweak-readme branch October 17, 2023 20:48
@github-actions github-actions bot locked and limited conversation to collaborators Nov 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@aminvakil aminvakil aminvakil left review comments

@chadwhitacre chadwhitacre chadwhitacre approved these changes

@azaslavsky azaslavsky azaslavsky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Self-hosted Sentry
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong command flag "--skip-user-prompt" in readme file
4 participants
@hubertdeng123 @chadwhitacre @azaslavsky @aminvakil