Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add issue platform infra #2309

Merged
merged 4 commits into from
Aug 4, 2023
Merged

Add issue platform infra #2309

merged 4 commits into from
Aug 4, 2023

Conversation

hubertdeng123
Copy link
Member

@hubertdeng123 hubertdeng123 commented Jul 28, 2023 •
edited
Loading

Yes, I know...more containers. 😬

adds issue platform infra for #2269

@hubertdeng123 hubertdeng123 marked this pull request as draft July 31, 2023 16:50
@hubertdeng123 hubertdeng123 marked this pull request as ready for review August 2, 2023 21:33
@hubertdeng123
Copy link
Member Author

I have this working now.
Screenshot 2023-08-02 at 2 33 32 PM

@hubertdeng123
Copy link
Member Author

Needs getsentry/arroyo#275

or else arroyo will complain

@hubertdeng123 hubertdeng123 requested a review from a team August 2, 2023 23:23
azaslavsky
azaslavsky approved these changes Aug 4, 2023
View reviewed changes
Copy link
Contributor

@azaslavsky azaslavsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this LGTM, but tbh I don't know much about the setups for these services. I think it'd be best to get reviews from folks on the Snuba, Ingest, and Issues teams before merging.

@hubertdeng123
Copy link
Member Author

I think it'd be best to get reviews from folks on the Snuba, Ingest, and Issues teams before merging.

Dameli and Dan from issues have looked over this PR, so going to call it good

@hubertdeng123 hubertdeng123 merged commit 09b6236 into master Aug 4, 2023
8 checks passed
@hubertdeng123 hubertdeng123 deleted the hubertdeng123/enable-issue-platform branch August 4, 2023 20:58
@hubertdeng123 hubertdeng123 mentioned this pull request Aug 7, 2023
Closed
2 tasks
@github-actions github-actions bot locked and limited conversation to collaborators Aug 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@azaslavsky azaslavsky azaslavsky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hubertdeng123 @azaslavsky