Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nginx to 1.25.1 #2235

Merged
merged 3 commits into from
Jun 30, 2023
Merged

Update nginx to 1.25.1 #2235

merged 3 commits into from
Jun 30, 2023

Conversation

williamdes
Copy link
Contributor

@williamdes williamdes commented Jun 26, 2023

LGTM the changelog: https://nginx.org/en/CHANGES-1.24
1.23 LGTM: https://nginx.org/en/CHANGES
and 1.22 only had a .1 with CVE fixes

1.25 is still a bit new, maybe we should wait before bumping: https://endoflife.date/nginx

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@williamdes williamdes closed this Jun 26, 2023
@williamdes williamdes reopened this Jun 26, 2023
Copy link
Collaborator

@aminvakil aminvakil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have a very simple use of nginx and I don't think we will face a problem using 1.25.1, let's bump it to latest version.

docker-compose.yml Outdated Show resolved Hide resolved
Co-authored-by: Amin Vakil <[email protected]>
@aminvakil
Copy link
Collaborator

Can you also please correct the PR title?

@aminvakil aminvakil closed this Jun 28, 2023
@aminvakil aminvakil reopened this Jun 28, 2023
@williamdes williamdes changed the title Update nginx to 1.24.0 Update nginx to 1.25.1 Jun 28, 2023
@williamdes
Copy link
Contributor Author

Can you also please correct the PR title?

Done

@hubertdeng123 hubertdeng123 merged commit 15fa264 into getsentry:master Jun 30, 2023
6 checks passed
@williamdes williamdes deleted the nginx-bump branch June 30, 2023 19:47
@github-actions github-actions bot locked and limited conversation to collaborators Jul 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants