Add opt in error monitoring to reset and clean scripts

[hubertdeng123]

Adds error monitoring to reset.sh and clean.sh

[chadwhitacre]

Here's a new one:

$ ./clean.sh 
▶ Initializing Docker Compose ...

▶ Detecting Docker platform
template: :1:2: executing "" at <.Architecture>: reflect: indirection through nil pointer to embedded struct field Info
FAIL: Unsupported docker architecture .
$

[hubertdeng123]

is this an issue that you're seeing after running the script?

[hubertdeng123]

moved a significant part of this file to docker_cleanup so that this can serve as a top level file for error-reporting

[hubertdeng123]

Some sample events:
https://self-hosted.getsentry.net/organizations/self-hosted/issues/341/?query=is%3Aignored&referrer=issue-stream
https://self-hosted.getsentry.net/organizations/self-hosted/issues/344/?query=is%3Aignored&referrer=issue-stream
https://self-hosted.getsentry.net/organizations/self-hosted/issues/345/?query=is%3Aignored&referrer=issue-stream

[chadwhitacre]

Not a fan of this diff. Why the excessive duplication? The only thing different is the logfile name and the install.sh call. If it's that hard to dedupe then maybe we should just drop the install.sh from reset.sh entirely (and remove clean.sh).

$ diff -rub clean.sh reset.sh
--- clean.sh	2023-03-14 17:46:08
+++ reset.sh	2023-03-14 17:46:08
@@ -1,11 +1,13 @@
 #!/usr/bin/env bash
 set -euo pipefail
 
+# Variables needing default values set in order to source install/error-handling
 MINIMIZE_DOWNTIME="${MINIMIZE_DOWNTIME:-}"
 STOP_TIMEOUT=60
+MSYSTEM="${MSYSTEM:-}"
 
 # Save logs in order to send envelope to Sentry
-log_file=sentry_clean_log-$(date +'%Y-%m-%d_%H-%M-%S').txt
+log_file=sentry_reset_log-$(date +'%Y-%m-%d_%H-%M-%S').txt
 exec &> >(tee -a "$log_file")
 version=$1
 
@@ -23,3 +25,4 @@
 source install/error-handling.sh
 trap_with_arg cleanup ERR INT TERM EXIT
 source docker_cleanup.sh $version
+source install.sh

[hubertdeng123]

How's this instead? Still some duplicate code but it's much cleaner

$ diff -rub clean.sh reset.sh
--- clean.sh    2023-03-14 16:27:17
+++ reset.sh    2023-03-14 16:27:17
@@ -1,5 +1,9 @@
 #!/usr/bin/env bash
-log_name=clean
 
+# Needed variable to source install script
+MSYSTEM="${MSYSTEM:-}"
+log_name=reset
+
 source set-up-error-reporting-for-scripts.sh
 source docker-cleanup.sh
+source install.sh