Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert symbolicator tests #2004

Merged
merged 1 commit into from
Mar 2, 2023
Merged

Revert symbolicator tests #2004

merged 1 commit into from
Mar 2, 2023

Conversation

hubertdeng123
Copy link
Member

Reverting changes made in #1916

Reasons:

  1. Self-hosted e2e test action is broken, but it's passing CI for some reason
  2. Tests have bene failing since this went in. Even on that PR, the self hosted e2e action failed on symbolicator tests but it came up with the green checkmark (CI here from PR)
  3. The symbolicator test has been extra flaky for our self-hosted integration tests. My hunch is that once self hosted e2e test action properly fails, it will increase the pain felt in sentry, snuba, and relay. See here for example

@hubertdeng123 hubertdeng123 merged commit da640d1 into master Mar 2, 2023
@hubertdeng123 hubertdeng123 deleted the hubertdeng123/revert-symbolicator-tests branch March 2, 2023 22:29
@hubertdeng123 hubertdeng123 mentioned this pull request Mar 3, 2023
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chadwhitacre chadwhitacre chadwhitacre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Self-hosted Sentry
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hubertdeng123 @chadwhitacre