Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set higher kafka healthcheck timeout #1855

Merged
merged 2 commits into from
Dec 8, 2022
Merged

Set higher kafka healthcheck timeout #1855

merged 2 commits into from
Dec 8, 2022

Conversation

ethanhs
Copy link
Contributor

@ethanhs ethanhs commented Dec 8, 2022

chadwhitacre
chadwhitacre reviewed Dec 8, 2022
View reviewed changes
docker-compose.yml Outdated Show resolved Hide resolved
chadwhitacre
chadwhitacre requested changes Dec 8, 2022
View reviewed changes
Copy link
Member

@chadwhitacre chadwhitacre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like seeing the quick knock-out, not sure the semantics are as intended tho?

@ethanhs
Fix timings for healthchecks
4b70374 
This reduces the time before we fail a healthcheck, based on the docs.
@ethanhs
Copy link
Contributor Author

ethanhs commented Dec 8, 2022

not sure the semantics are as intended tho?

Fixed!

@hubertdeng123 hubertdeng123 changed the title Set higher kafka helathcheck timeout Set higher kafka healthcheck timeout Dec 8, 2022
@ethanhs ethanhs merged commit dbb89bf into master Dec 8, 2022
@ethanhs ethanhs deleted the ethanhs/kafka-timeout-increase branch December 8, 2022 18:38
@github-actions github-actions bot locked and limited conversation to collaborators Dec 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chadwhitacre chadwhitacre chadwhitacre approved these changes

@hubertdeng123 hubertdeng123 hubertdeng123 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ethanhs @chadwhitacre @hubertdeng123