Fix minimum version requirements for docker and docker compose #1732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BYK
approved these changes
Oct 3, 2022
hubertdeng123
commented
Oct 3, 2022
| @@ -13,14 +13,14 @@ if [[ -z "$DOCKER_VERSION" ]]; then | |||
| exit 1 | |||
| fi | |||
|
|
|||
| if [[ "$(vergte ${DOCKER_VERSION//v} $MIN_DOCKER_VERSION)" ]]; then | |||
| if [[ "$(vergte ${DOCKER_VERSION//v} $MIN_DOCKER_VERSION)" -eq 1 ]]; then | |||
There was a problem hiding this comment.
Equal comparison is needed for this to succeed
hubertdeng123
changed the title
27 tasks
hubertdeng123
deleted the
hubertdeng123/fix-minimum-version-requirements
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function vergte here doesn't correctly use the return code in order to be used in version comparison. As a result, users are running older versions of docker compose. The issue with the largest number of events in our dogfood instance seems to be a result of folks using an older version of docker compose, then erroring out later during the turn things off script.
This fixes the issue here:
#1706