Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix traceback hash for error monitoring #1700

Merged
merged 1 commit into from
Sep 14, 2022
Merged

Fix traceback hash for error monitoring #1700

merged 1 commit into from
Sep 14, 2022

Conversation

hubertdeng123
Copy link
Member

add -i flag to keep STDIN open even if not attached
We were hashing an empty string before 😬

ethanhs
ethanhs approved these changes Sep 14, 2022
View reviewed changes
Copy link
Contributor

@ethanhs ethanhs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@hubertdeng123 hubertdeng123 enabled auto-merge (squash) September 14, 2022 21:20
@hubertdeng123 hubertdeng123 merged commit 75990a8 into master Sep 14, 2022
@hubertdeng123 hubertdeng123 deleted the fix/dogfood-fingerprinting branch September 14, 2022 21:34
@hubertdeng123 hubertdeng123 mentioned this pull request Sep 14, 2022
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ethanhs ethanhs ethanhs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hubertdeng123 @ethanhs