Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup .env{,.custom} handling #1539

Merged
merged 1 commit into from
Jun 28, 2022
Merged

Cleanup .env{,.custom} handling #1539

merged 1 commit into from
Jun 28, 2022

Conversation

chadwhitacre
Copy link
Member

Fixes #941, also addresses the suggestion for a README tweak at the very bottom of #1491 (comment).

Look good to you, @aminvakil @glensc @Daniel15?

Daniel15
Daniel15 reviewed Jun 23, 2022
View reviewed changes
install/_lib.sh Outdated Show resolved Hide resolved
@Daniel15
Copy link

This looks good to me!

@aminvakil
Copy link
Collaborator

I tested this locally on a clean machine (running ./integration-test.sh) and faced this error:

./_integration-test/../install/_lib.sh: line 28: /home/fedora/self-hosted/_integration-test/.env: No such file or directory

@chadwhitacre
Copy link
Member Author

What's up with CI? 🤔

  time="2022-06-23T00:09:18Z" level=warning msg="The \"HEALTHCHECK_INTERVAL\" variable is not set. Defaulting to a blank string."
  time="2022-06-23T00:09:18Z" level=warning msg="The \"HEALTHCHECK_TIMEOUT\" variable is not set. Defaulting to a blank string."
  time="2022-06-23T00:09:18Z" level=warning msg="The \"HEALTHCHECK_RETRIES\" variable is not set. Defaulting to a blank string."
  time="2022-06-23T00:09:18Z" level=warning msg="The \"SNUBA_IMAGE\" variable is not set. Defaulting to a blank string."
  time="2022-06-23T00:09:18Z" level=warning msg="The \"SENTRY_BIND\" variable is not set. Defaulting to a blank string."
  time="2022-06-23T00:09:18Z" level=warning msg="The \"HEALTHCHECK_TIMEOUT\" variable is not set. Defaulting to a blank string."
  time="2022-06-23T00:09:18Z" level=warning msg="The \"HEALTHCHECK_RETRIES\" variable is not set. Defaulting to a blank string."
  error while interpolating services.redis.healthcheck.retries: failed to cast to expected type: strconv.Atoi: parsing "": invalid syntax

https://github.com/getsentry/self-hosted/runs/7014638001?check_suite_focus=true#step:4:1313

This isn't a familiar CI flake. Is it authentic?

@chadwhitacre
Copy link
Member Author

Is it authentic?

Yup, and it's downstream of @aminvakil's result:

./_integration-test/../install/_lib.sh: line 28: /home/runner/work/self-hosted/self-hosted/_integration-test/.env: No such file or directory

https://github.com/getsentry/self-hosted/runs/7096779775?check_suite_focus=true#step:4:1258

@chadwhitacre chadwhitacre enabled auto-merge (squash) June 28, 2022 17:04
ethanhs
ethanhs approved these changes Jun 28, 2022
View reviewed changes
Copy link
Contributor

@ethanhs ethanhs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good!

Its a shame there isn't a shell linter that reports macOS/linux incompatibilities :/

@chadwhitacre
Copy link
Member Author

a shell linter that reports macOS/linux incompatibilities

Oooooh ... good idea! :)

@chadwhitacre chadwhitacre merged commit 1852fe8 into master Jun 28, 2022
@chadwhitacre chadwhitacre deleted the cwlw/portable-absolute-path branch June 28, 2022 17:19
@github-actions github-actions bot locked and limited conversation to collaborators Jul 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Daniel15 Daniel15 Daniel15 left review comments

@ethanhs ethanhs ethanhs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reference to realpath in install script breaks macOS compatibility
4 participants
@chadwhitacre @Daniel15 @aminvakil @ethanhs