Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run release a new version job only on getsentry #1529

Merged
merged 1 commit into from
Jun 22, 2022

Conversation

aminvakil
Copy link
Collaborator

In order to prevent a failed job run on forked repositories :)

For example:
https://github.com/aminvakil/self-hosted/runs/6905699181?check_suite_focus=true

It fails instantly right now with Error: Input required and not supplied: token, but why it should be run on forked repositories anyway?

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@aminvakil
Copy link
Collaborator Author

Failing CI is related to #1294 (comment), closing and reopening to run CI again.

@aminvakil aminvakil closed this Jun 19, 2022
@aminvakil aminvakil reopened this Jun 19, 2022
Copy link
Member

@BYK BYK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

Copy link
Member

@chadwhitacre chadwhitacre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. This should be on all pre-release workflows in getsentry.

@chadwhitacre chadwhitacre merged commit f2fb758 into getsentry:master Jun 22, 2022
@aminvakil aminvakil deleted the release_fork_repo branch June 25, 2022 18:19
@github-actions github-actions bot locked and limited conversation to collaborators Jul 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants