Document From email display name #1446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BYK
approved these changes
May 11, 2022
|
Is this accurate to what you did @marguspeet? |
|
Should also mention it somewhere here: https://develop.sentry.dev/self-hosted/email/ |
|
Or even better, here: https://develop.sentry.dev/services/email/#outbound-email |
|
I considered the self-hosted email docs but "set a valid address for mail.from setting in config.yml" is good enough there, points to the file and then with this PR you have what you need once you get there. The more general doc is probably worth updating ... getsentry/develop#575. |
|
Agree with @BYK should also update web page. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To prevent recurrences of getsentry/sentry#34387