Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring in CLA Lite #1439

Merged
merged 4 commits into from
May 10, 2022
Merged

Bring in CLA Lite #1439

merged 4 commits into from
May 10, 2022

Conversation

chadwhitacre
Copy link
Member

@chadwhitacre
Copy link
Member Author

FYI gonna workshop this language to be more on-brand, marking draft for now

@BYK
Copy link
Member

BYK commented May 3, 2022

Without a bot, this is quite tedious to enforce. Moreover, you should probably find a way to make these into commit logs. Not sure if merge queue would help.

@chadwhitacre
Copy link
Member Author

Not sure what you're envisioning. All we're going for is a simple boilerplate in the PR template, not a heavy CLA system.

@BYK
Copy link
Member

BYK commented May 3, 2022

All we're going for is a simple boilerplate in the PR template, not a heavy CLA system.

I get it and applaud it. The issue is, for people like me who use the command line to create PRs, I don't get the PR template, I don't even see it. And we also know folks who like to delete any kind of issue/PR templates without even looking. So I'm just recommending adding a GitHub Action that checks that final string exists in the PR description or blocks the PR with a good error message.

Making sure the PR body ends up in the final squash commit would also be beneficial for legal reasons but that's harder to achieve, hence my reference to the merge queue.

@chadwhitacre
Copy link
Member Author

Fair points. I checked with Legal and the PR template is satisfactory for now. If we end up flooded with external PRs that dodge this language we can revisit.

Still need to give the verbiage that Sentry flair tho ... ;)


----

By submitting this pull request, I confirm that Sentry can use, modify, copy, and redistribute this contribution, under Sentry's choice of terms.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
By submitting this pull request, I confirm that Sentry can use, modify, copy, and redistribute this contribution, under Sentry's choice of terms.
By submitting this pull request, I acknowledge that I love Sentry by letting them use, modify, copy, and redistribute my organic and artisanal code that does not violate anyone else's rights without any limitations. I also acknowledge that this is some boring legalese but my love of Sentry trumps anything.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chadwhitacre

Still need to give the verbiage that Sentry flair tho ... ;)

How about something like this? :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am running this by our new creative director. 😜

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

loving @BYK 's input here

@chadwhitacre chadwhitacre force-pushed the cwlw/cla-lite branch 2 times, most recently from 5e8a9b1 to f043a36 Compare May 10, 2022 21:26
@chadwhitacre chadwhitacre marked this pull request as ready for review May 10, 2022 21:28
@chadwhitacre chadwhitacre enabled auto-merge (squash) May 10, 2022 21:30
Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

Copy link
Member

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@chadwhitacre chadwhitacre merged commit 30b7c62 into master May 10, 2022
@chadwhitacre chadwhitacre deleted the cwlw/cla-lite branch May 10, 2022 22:13
@github-actions github-actions bot locked and limited conversation to collaborators May 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants