-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bring in CLA Lite #1439
Bring in CLA Lite #1439
Conversation
FYI gonna workshop this language to be more on-brand, marking draft for now |
Without a bot, this is quite tedious to enforce. Moreover, you should probably find a way to make these into commit logs. Not sure if merge queue would help. |
Not sure what you're envisioning. All we're going for is a simple boilerplate in the PR template, not a heavy CLA system. |
I get it and applaud it. The issue is, for people like me who use the command line to create PRs, I don't get the PR template, I don't even see it. And we also know folks who like to delete any kind of issue/PR templates without even looking. So I'm just recommending adding a GitHub Action that checks that final string exists in the PR description or blocks the PR with a good error message. Making sure the PR body ends up in the final squash commit would also be beneficial for legal reasons but that's harder to achieve, hence my reference to the merge queue. |
Fair points. I checked with Legal and the PR template is satisfactory for now. If we end up flooded with external PRs that dodge this language we can revisit. Still need to give the verbiage that Sentry flair tho ... ;) |
.github/PULL_REQUEST_TEMPLATE.md
Outdated
|
||
---- | ||
|
||
By submitting this pull request, I confirm that Sentry can use, modify, copy, and redistribute this contribution, under Sentry's choice of terms. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By submitting this pull request, I confirm that Sentry can use, modify, copy, and redistribute this contribution, under Sentry's choice of terms. | |
By submitting this pull request, I acknowledge that I love Sentry by letting them use, modify, copy, and redistribute my organic and artisanal code that does not violate anyone else's rights without any limitations. I also acknowledge that this is some boring legalese but my love of Sentry trumps anything. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still need to give the verbiage that Sentry flair tho ... ;)
How about something like this? :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am running this by our new creative director. 😜
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
loving @BYK 's input here
075b204
to
733baa4
Compare
5e8a9b1
to
f043a36
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RSLGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See getsentry/.github#92.