fix(requirements): Make compose version check bw-compatible #1068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -8,7 +8,8 @@ MIN_CPU_HARD=2 | |||
| MIN_CPU_SOFT=4 | |||
|
|
|||
| DOCKER_VERSION=$(docker version --format '{{.Server.Version}}') | |||
| COMPOSE_VERSION=$($dc --version | sed 's/docker-compose version \(.\{1,\}\),.*/\1/') | |||
| # Do NOT use $dc instead of `docker-compose` below as older versions don't support certain options and fail | |||
| COMPOSE_VERSION=$(docker-compose --version | sed 's/docker-compose version \(.\{1,\}\),.*/\1/') | |||
There was a problem hiding this comment.
Does the "docker-compose → docker compose" warning/notice leak through here? If so, do we want to suppress it, perhaps by redirecting stderr?
There was a problem hiding this comment.
Nope:
$ docker-compose --version
docker-compose version 1.29.2, build 5becea4c
chadwhitacre
approved these changes
Aug 18, 2021
BYK
added a commit
that referenced
this pull request
Aug 19, 2021
BYK
added a commit
that referenced
this pull request
Aug 19, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #1062.