Question about installation with http_proxy

[lemrouch]

Problem Statement

I'm trying to install Sentry behind firewall.
Code in https://github.com/getsentry/self-hosted/pull/1543/files is

RUN if [ -z "${http_proxy}" ]; then echo "Acquire::http::proxy \"${http_proxy}\";" >> /etc/apt/apt.conf; fi
RUN if [ -z "${https_proxy}" ]; then echo "Acquire::https::proxy \"${https_proxy}\";" >> /etc/apt/apt.conf; fi

In my experience and documentation -z in test means if the string is empty therefore the config won't be set if there are actual values in http_proxy and/or https_proxy variables.

Solution Brainstorm

I guess the code was meant to be

RUN if [ ! -z "${http_proxy}" ]; then echo "Acquire::http::proxy \"${http_proxy}\";" >> /etc/apt/apt.conf; fi
RUN if [ ! -z "${https_proxy}" ]; then echo "Acquire::https::proxy \"${https_proxy}\";" >> /etc/apt/apt.conf; fi

or

RUN if [ -n "${http_proxy}" ]; then echo "Acquire::http::proxy \"${http_proxy}\";" >> /etc/apt/apt.conf; fi
RUN if [ -n "${https_proxy}" ]; then echo "Acquire::https::proxy \"${https_proxy}\";" >> /etc/apt/apt.conf; fi

Am I right or too tired?

[azaslavsky]

I think that's correct. Any interest in submitting a PR with the fix?