Skip to content

Commit

Permalink
fix
Browse files Browse the repository at this point in the history
  • Loading branch information
hubertdeng123 committed Apr 25, 2024
1 parent f52a3b5 commit dc44224
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 5 deletions.
3 changes: 3 additions & 0 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,9 @@ jobs:
sudo curl -L https://github.com/docker/compose/releases/download/${{ matrix.compose_version }}/docker-compose-`uname -s`-`uname -m` -o "${{ matrix.compose_path }}/docker-compose"
sudo chmod +x "${{ matrix.compose_path }}/docker-compose"
- name: Ensure runner is owner of /var/lib/docker to set permissions of docker volumes
run: sudo chown -R $(whoami):$(whoami) /var/lib/docker

- name: Install self-hosted
uses: nick-fields/retry@v3
with:
Expand Down
2 changes: 1 addition & 1 deletion _integration-test/conftest.py
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ def configure_self_hosted_environment(request):
with open("sentry/requirements.txt", "w") as req_file:
req_file.write("python-ldap\n")
os.environ["MINIMIZE_DOWNTIME"] = "1"
subprocess.run(["./install.sh"], check=True)
subprocess.run(["./install.sh"], check=True, capture_output=True)

Check warning on line 55 in _integration-test/conftest.py

View check run for this annotation

Codecov / codecov/patch

_integration-test/conftest.py#L55

Added line #L55 was not covered by tests
# Create test user
subprocess.run(
[
Expand Down
2 changes: 1 addition & 1 deletion install.sh
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@ source install/check-minimum-requirements.sh

# Let's go! Start impacting things.
source install/turn-things-off.sh
source install/create-docker-volumes.sh
source install/update-docker-volume-permissions.sh
source install/create-docker-volumes.sh
source install/ensure-files-from-examples.sh
source install/check-memcached-backend.sh
source install/ensure-relay-credentials.sh
Expand Down
6 changes: 3 additions & 3 deletions install/update-docker-volume-permissions.sh
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
echo "${_group}Ensuring Kafka and Zookeeper volumes have correct permissions ..."

if [[ "$DOCKER_PLATFORM" = "linux/amd64" ]]; then
if [[ "$DOCKER_PLATFORM" = "linux/amd64" && -n "$(docker volume ls -q -f name=sentry-zookeeper)" && -n "$(docker volume ls -q -f name=sentry-kafka)" ]]; then
chmod -R a+w /var/lib/docker/volumes/sentry-zookeeper/_data
chmod -R a+w /var/lib/docker/volumes/sentry-kafka/_data
chmod -R a+w /var/lib/docker/volumes/sentry-self-hosted_sentry-zookeeper-log/_data
chmod -R a+w /var/lib/docker/volumes/sentry-kafka/_data
chmod -R a+w /var/lib/docker/volumes/sentry-self-hosted_sentry-zookeeper-log/_data
fi

echo "${_endgroup}"

0 comments on commit dc44224

Please sign in to comment.