Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amend RFC 92 With New Options #99

Merged
merged 10 commits into from
Jun 1, 2023
Merged

Amend RFC 92 With New Options #99

merged 10 commits into from
Jun 1, 2023

Conversation

cmanallen
Copy link
Member

@cmanallen cmanallen commented May 30, 2023

- Requires SDK changes.
- Requies code changes by the Issues team to create a generic interface for creating issues.
- This would likely disrupt our June 18 deadline.
- Unless the Issues team has excess capacity and a willingness to work on it immediately.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it also seems like we'd also want to do this in Relay -- we try not to have python endpoints be hit by SDKs. seems like it would be a large amount of work.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like this would be the Issues teams problem... sorry @wedamija 😆. But seriously, I could contribute to this if the Issues team needs help. Dan do you have any feedback on option 2? (or any option really)

text/0092-replay-issue-creation.md Outdated Show resolved Hide resolved
text/0092-replay-issue-creation.md Outdated Show resolved Hide resolved
text/0092-replay-issue-creation.md Outdated Show resolved Hide resolved
text/0092-replay-issue-creation.md Outdated Show resolved Hide resolved
text/0092-replay-issue-creation.md Outdated Show resolved Hide resolved
text/0092-replay-issue-creation.md Show resolved Hide resolved
text/0092-replay-issue-creation.md Show resolved Hide resolved
@mitsuhiko
Copy link
Member

Out of the options here this really should be option 3. I don’t like the idea if creating issues directly from the SDK. On the one hand for abuse reasons, on the other for flexibility reasons if we want to change how these issues behave.

Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggested decision

text/0092-replay-issue-creation.md Outdated Show resolved Hide resolved
- Significantly smaller pool of customers who will see "slow click" issues.
- Requires code changes by the Session Replay back-end team.
- Requires addition of event sampling, issue platform integration, and merging of the replay-event and recording-event payloads.
- Merging the replay-event and recording-event payloads together is not a trivial change and requires careful deployment.

# Unresolved questions
Copy link
Member

@jas-kas jas-kas May 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For Option 1: SDK Creates Issues With "captureException" Method, we should think about:

  • How valuable and/or actionable are dead click issues without replays?
  • If we can provide dead click issues without Replay being installed, will customers be incentivized to install Replay?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should put both of these bullets as Cons inside (especially) option 1

text/0092-replay-issue-creation.md Show resolved Hide resolved
Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since they inverted the buttons, it really gets me

@cmanallen cmanallen merged commit c02dbb9 into main Jun 1, 2023
1 check passed
@cmanallen cmanallen deleted the cmanallen/update-rfc-92 branch June 1, 2023 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants