rfc(feature): Sentry Bundler Plugins API #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lforst
force-pushed
the
rfc/sentry-bundler-plugins-api
branch
from
db5ff59
to
190b378
Compare
lforst
requested review from
HazAT,
kamilogorek,
mydea,
Jesse-Box,
Lms24 and
AbhiPrasad
lforst
commented
Apr 14, 2023
AbhiPrasad
reviewed
Apr 14, 2023
AbhiPrasad
reviewed
Apr 17, 2023
Lms24
reviewed
Apr 17, 2023
|
Should we add an option to delete sourcemaps after upload? |
Co-authored-by: Lukas Stracke <[email protected]>
Not in this RFC. We will add a note in the changelog + migration guide. |
|
Ok, I think everything has been addressed. @Lms24 There is one open point about the rewriting - lmk if you think this is blocking, otherwise can anybody slap approve? cc @AbhiPrasad |
Nope, not blocking. |
Lms24
approved these changes
Apr 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We wanna update our bundler plugins API with the next major.
Rendered RFC