Source Hash Extension for Source Maps #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swatinem
reviewed
Apr 7, 2023
Comment on lines
+107
to
+109
| also want to add them to the manifest. For this we could leverage the digest | ||
| header, with the small suboptimal situation that the HTTP digest spec uses | ||
| a base64 hash: |
There was a problem hiding this comment.
We should just embrace the reality that the headers have nothing to do with HTTP anymore (even though they originally were inspired by that).
This is all a bit bikesheddy, but we should strive for consistency here between the protocol, the sourcemap JSON, and these headers. We use a mix of different names and string/objects all over the place.
I believe we are currently limited by headers being a String->String mapping. But we could relax that as well if needed.
There was a problem hiding this comment.
I would honestly just move all this stuff out of headers and keep toplevel, but as it stands these are actually still http headers in the current implementation. It really just overlays the HTTP fetch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This proposes and specifies support for source hashes in Sentry. This allows looking up source maps by the content hash of the transpiled / minified file. It leverages recent additions to Chrome and Edge (Caller.getScriptHash).
Relates to #81
Rendered RFC