Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Propose a new way to continue a trace #14

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
+64 −0
Open

Propose a new way to continue a trace #14

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5f9650b
Propose a new way to continue a trace
cleptric Sep 26, 2022
9b55122
Remove HTTP option
cleptric Sep 29, 2022
92c9d09
Add Drawbacks/Impact
cleptric Sep 29, 2022
cc6a66b
Correct method name
cleptric Sep 30, 2022
54620cf
Clarify use case
cleptric Sep 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Clarify use case
  • Loading branch information
@cleptric
cleptric committed Sep 30, 2022
commit 54620cfa52c984141617046c754986195e0d1244
1 change: 1 addition & 0 deletions text/0014-continue-traces.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ $transaction = startTransaction($transactionContext);
```

In case someone starts another nested transaction without passing in any context, a new trace will be started and the Dynamic Sampling Context is lost as well.
Using transactions inside transactions was a workaround as the span summary view was not available back then.

# Options Considered

Expand Down