Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rfc(decision): Mobile - Tracing Without Performance V2 #136

Closed
wants to merge 9 commits into from
Closed

rfc(decision): Mobile - Tracing Without Performance V2 #136

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
313a0a0
rfc(decision): Mobile - Tracing Without Performance V2
philipphofmann Jun 4, 2024
27c44c4
first version
philipphofmann Jun 4, 2024
a68b563
add cons
philipphofmann Jun 4, 2024
e3be25a
Update text/0136-mobile-tracing-without-performance-v-2.md
philipphofmann Jun 5, 2024
3a70e7b
add session logic
philipphofmann Jun 6, 2024
9c252cc
Update text/0136-mobile-tracing-without-performance-v-2.md
philipphofmann Jun 10, 2024
fddeeaa
Update text/0136-mobile-tracing-without-performance-v-2.md
philipphofmann Jun 10, 2024
764196a
spans across screens
philipphofmann Jun 10, 2024
cd840eb
add route to the title
philipphofmann Jun 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Prev Previous commit
Next Next commit
spans across screens
  • Loading branch information
@philipphofmann
philipphofmann committed Jun 10, 2024
commit 764196a99a1516b6b88a26383fd537b4d72d5d8e
4 changes: 3 additions & 1 deletion text/0136-mobile-tracing-without-performance-v-2.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,9 @@ foreground after being in the background for longer than 30 seconds, which is th
mobile SDKs use for determining the end of a session, mobile SDKs renew the `traceId` of the
PropagationContext. If the app stays in the background for shorter or equal to 30 seconds,
mobile SDKs must not renew the `traceId` of the PropagationContext when the app moves again to
the foreground.
the foreground. When a span starts, SDKs should use the traceID on the PropagationContext, but
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't this break transaction/spans sample rates?
The sampled state of the PropagationContext would overwrite the calculated sampling decision of the span done through tracesSampleRate - or even worse through tracesSampler

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or are we just saying to use the traceId of the PropagationContext, retaining the usual sample decision?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

continuing below

SDKs make an exception to this rule to map all spans related to a screen/route to the same traceID.
For example, when a span leads to a new screen, SDKs should use the traceID of the new screen.

### Pros <a name="option-1-pros"></a>

Expand Down