Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Clarify span op/description for metric correlation in span creating mode #133

Merged
merged 1 commit into from
Mar 8, 2024
Merged

docs: Clarify span op/description for metric correlation in span creating mode #133

merged 1 commit into from
Mar 8, 2024

Conversation

markushi
Copy link
Member

@markushi markushi commented Mar 4, 2024 •
edited
Loading

philipphofmann
philipphofmann approved these changes Mar 8, 2024
View reviewed changes
Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 🚀

@markushi markushi merged commit 851317a into main Mar 8, 2024
2 checks passed
@markushi markushi deleted the markushi/metric-span-correlation-docs branch March 8, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philipphofmann philipphofmann philipphofmann approved these changes

@sl0thentr0py sl0thentr0py sl0thentr0py approved these changes

@mitsuhiko mitsuhiko Awaiting requested review from mitsuhiko

@cleptric cleptric Awaiting requested review from cleptric

@bitsandfoxes bitsandfoxes Awaiting requested review from bitsandfoxes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@markushi @philipphofmann @sl0thentr0py