rfc(feature): Pass Native SDKs Spans to Hybrid #131
Conversation
philipphofmann
force-pushed
the
rfc/rfcfeature-native-to-hybrid-sdk-spans-passing
branch
from
e5988da
to
5f77cf2
Compare
philipphofmann
changed the title
philipphofmann
changed the title
philipphofmann
requested review from
markushi,
kahest,
buenaflor and
stefanosiano
Co-authored-by: Dhiogo Brustolin <[email protected]>
|
|
||
| ### Pros <a name="option-3-pros"></a> | ||
|
|
||
| 1. This option works well with idle transactions and `waitForChildren` because these concepts need to |
There was a problem hiding this comment.
is this a clear advantage over the aggregate callback when all spans are finished outlined for option 2?
|
Option 2 looks to me the best as no span will be lost and the communication over the bridge is kept at a minimum. |
Co-authored-by: Karl Heinz Struggl <[email protected]>
| actual native operations take. It could happen that one DB query from the hybrid layer gets | ||
| converted into multiple native DB queries. Such information would be insightful for our users. | ||
| Furthermore, there could be native-only operations that our hybrid SDKs currently don't capture. Therefore, | ||
| we want to pass native spans up to the native layers so users know what's happening on the native layer. |
There was a problem hiding this comment.
in a world of ingesting only spans, do we need to pass them across layers?
Would it dumping straight to the transport be enough while having them on the same trace?
There was a problem hiding this comment.
That's an excellent question. We want to establish a parent-child relationship between some spans, which works best when passing spans from native to RN because, on the backend, it's tricky if the spans don't arrive there in the same envelope. I will update the RFC to explain this.
There was a problem hiding this comment.
I added your suggestion as option 4. Feel free to directly commit pros and cons, @bruno-garcia.
Co-authored-by: Karl Heinz Struggl <[email protected]>
philipphofmann
deleted the
rfc/rfcfeature-native-to-hybrid-sdk-spans-passing
branch
This RFC aims to find a solution for passing auto-instrumented native SDK spans up to the hybrid SDKs.
Rendered RFC