Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rfc(feature): Video replay envelope #129

Merged
merged 26 commits into from
Feb 9, 2024
Merged

rfc(feature): Video replay envelope #129

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
8ccece4
rfc(feature): Video replay envelope
vaind Feb 6, 2024
985c32c
basics
vaind Feb 6, 2024
7691ba5
intro
vaind Feb 6, 2024
26ee3cc
some ideas
vaind Feb 6, 2024
b4d3723
motivation update
vaind Feb 6, 2024
ae41a9d
Update text/0129-video-replay-envelope.md
vaind Feb 7, 2024
a653d99
review changes
vaind Feb 7, 2024
5574b37
rework the proposed option
vaind Feb 8, 2024
14f517b
cleanups
vaind Feb 8, 2024
3c60f03
apply review suggestions
vaind Feb 8, 2024
75aba68
Update text/0129-video-replay-envelope.md
vaind Feb 8, 2024
46c72b8
review suggestions and clarification
vaind Feb 8, 2024
ab3db0d
improvements
vaind Feb 8, 2024
8843512
details
vaind Feb 8, 2024
c2e004e
fixup rrweb json
vaind Feb 8, 2024
e22a091
cleanup
vaind Feb 8, 2024
cb938e5
Update text/0129-video-replay-envelope.md
vaind Feb 9, 2024
e9488b1
camel case & header cleanup
vaind Feb 9, 2024
78987fb
add meta event & left+top
vaind Feb 9, 2024
79ef51f
fixup case on relay header
vaind Feb 9, 2024
1e20ad4
Update text/0129-video-replay-envelope.md
romtsn Feb 9, 2024
2424b31
Update text/0129-video-replay-envelope.md
vaind Feb 9, 2024
70e1b05
cleanup & clarify envelope items headers vs payloads
vaind Feb 9, 2024
6260eaa
Update text/0129-video-replay-envelope.md
vaind Feb 9, 2024
d4dd02a
update the RFC status
vaind Feb 9, 2024
fc78a2b
add rough image vs video size comparison info
vaind Feb 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
basics
  • Loading branch information
@vaind
vaind committed Feb 6, 2024
commit 985c32c57fe1bfc5f6cc4e1208d8fd8a4dfdae87
1 change: 1 addition & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,3 +61,4 @@ This repository contains RFCs and DACIs. Lost?
- [0118-mobile-transactions-and-spans](text/0118-mobile-transactions-and-spans.md): Transactions and Spans for Mobile Platforms
- [0123-metrics-correlation](text/0123-metrics-correlation.md): This RFC addresses the high level metrics to span correlation system
- [0126-sdk-spans-aggregator](text/0126-sdk-spans-aggregator.md): SDK Span Buffer
- [0129-video-replay-envelope](text/0129-video-replay-envelope.md): Video-based replay envelope format
6 changes: 3 additions & 3 deletions text/0129-video-replay-envelope.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
- Start Date: YYYY-MM-DD
- RFC Type: feature / decision / informational
- RFC PR: <link>
- Start Date: 2024-02-06
- RFC Type: feature
- RFC PR: [#129](https://github.com/getsentry/rfcs/pull/129)
- RFC Status: draft

# Summary
Expand Down