Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rfc(decision): Propagation Context Evolution #127

Closed
wants to merge 2 commits into from

Conversation

lforst
Copy link
Member

@lforst lforst commented Feb 6, 2024

Proposal to make propagation context not required on scopes.

Rendered RFC

@lforst lforst force-pushed the rfc/propagation-context-evolution branch from ffd8d35 to 139f514 Compare February 6, 2024 09:22
@lforst lforst marked this pull request as ready for review February 6, 2024 12:17
@mydea
Copy link
Member

mydea commented Feb 7, 2024

This makes sense to me - we just need to make sure there are no unexpected consequences of this, but IMHO this appears more correct to me than what we have been doing.
One area to think about there is replay, as a replay will then span multiple traces which it does not do right now! Cc @billyvg thoughts on implications of this? Would this make sense? Or should we only attach the "first" (pageload) trace to the replay?

@lforst
Copy link
Member Author

lforst commented Feb 7, 2024

This makes sense to me - we just need to make sure there are no unexpected consequences of this, but IMHO this appears more correct to me than what we have been doing. One area to think about there is replay, as a replay will then span multiple traces which it does not do right now! Cc @billyvg thoughts on implications of this? Would this make sense? Or should we only attach the "first" (pageload) trace to the replay?

A replay should imo not have a trace ID. That doesn't make sense because a replay can span multiple traces, e.g. a pageload trace and multiple navigation traces. However, all the things (errors, spans, profiles) that happen within a replay should have a replay ID. That replay ID is currently also propagated with baggage so that downstream services can also attach to a particular replay.

It's good to keep replay in mind for this, but it shouldn't be a blocker here I think! (at least conceptually)

@billyvg
Copy link
Member

billyvg commented Feb 7, 2024

Yeah the replay itself shouldn't have a trace id, since it lives beyond multiple traces. Replay collects the trace ids of all events that occur while the replay is running. If we do erroneously attach a trace id to the replay, I don't believe that we use it in any way.

@lforst
Copy link
Member Author

lforst commented Feb 15, 2024

Closing. We will have a PR for this in the develop docs.

@lforst lforst closed this Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants