ref: Amend span creation names for RFC 101 #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sounds good to me!|
I wasn't present during the discussion that led to this change so I don't want to approve on behalf of folks that were but wanted to say this change sounds great! Definitely makes the API more intuitive. |
Lms24
approved these changes
Sep 7, 2023
There was a problem hiding this comment.
Nice! I'm still not a fan of the "start" naming in the callback-based API (would have preferred something like trace) but this is just bike-shedding at this point and I also see the value in keeping this at least somewhat consistent across SDKs. Thanks for updating!
AbhiPrasad
added a commit
to getsentry/sentry-javascript
that referenced
this pull request
Sep 7, 2023
As per the new changes in RFC 101 in getsentry/rfcs#113, update the span performance API names. - `startActiveSpan` -> `startSpan` - `startSpan` -> `startInactiveSpan` https://github.com/getsentry/rfcs/blob/main/text/0101-revamping-the-sdk-performance-api.md `startActiveSpan` is deprecated, while `startInactiveSpan` is being introduced. The breaking change is that `startSpan` is being changed, but considering that basically no-one is using the `startSpan` API, we should be fine to break here for correctness reasons. Better break now than to have everyone refactor their code in v8.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussed offline we decided to change the names of the span creator methods.
startActiveSpan->startSpanstartSpan->startInactiveSpanlmk what you all think!